cha0s/avocado-old
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: remove destroy emitters

Browse Source
This commit is contained in:
cha0s 2019-11-06 00:08:21 -06:00
parent 5cfc18a2aa
commit 7cb4d21f5a
1 changed files with 9 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
packages/physics/traits/emitter.trait.js
View File

@ -171,13 +171,17 @@ export class Emitter extends decorate(Trait) {
this.entity.emitParticleJson(mergedJson);
count -= 1;
if (count > 0) {
const removeEmission = () => {
const index = this.emissions.indexOf(ticker);
if (-1 !== index) {
this.emissions.splice(index, 1);
}
};
this.entity.on('destroy', removeEmission);
ticker.on('tick', () => {
this.emitParticleJson(mergedJson);
this.entity.emitParticleJson(mergedJson);
if (0 === --count) {
const index = this.emissions.indexOf(ticker);
if (-1 !== index) {
this.emissions.splice(index, 1);
}
removeEmission();
}
});
this.emissions.push(ticker);