cha0s/avocado-old
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: unloop and avoid null traits from immediate destroy

Browse Source
This commit is contained in:
cha0s 2019-05-03 08:17:18 -05:00
parent 643f2bbf62
commit c53a3308ee
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
packages/entity/index.js
View File

@ -245,7 +245,7 @@ export class Entity extends decorate(Resource) {
// Remove instance.
delete this._traits[type];
// Unloop.
// instance.entity = undefined;
instance.entity = undefined;
}
removeTraits(types) {
@ -261,6 +261,11 @@ export class Entity extends decorate(Resource) {
tick(elapsed) {
for (const type in this._traits) {
// If .destroy is called immediately when ticking a trait, then the next
// traits could go away.
if (!(type in this._traits)) {
continue;
}
const instance = this._traits[type];
instance.tick(elapsed);
}