cha0s/avocado-old
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

perf: only use entity position once

Browse Source
This commit is contained in:
cha0s 2019-05-01 20:16:38 -05:00
parent 548e206bc9
commit d6d18dbd24
3 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
packages/graphics/traits/pictured.trait.js
View File

@ -129,9 +129,8 @@ export class Pictured extends decorate(Trait) {
return [0, 0, 0, 0];
}
const viewPosition = this.offsetFor(key);
const position = Vector.add(this.entity.position, viewPosition);
const size = this.sizeFor(key);
const rectangle = Rectangle.compose(position, size);
const rectangle = Rectangle.compose(viewPosition, size);
const expanded = Rectangle.expand(
rectangle,
Vector.sub(Vector.mul(size, this.entity.rawVisibleScale), size),

6
packages/graphics/traits/visible.trait.js
View File

@ -205,7 +205,11 @@ export class Visible extends decorate(Trait) {
visibleAabb,
);
}
this.visibleAabb = unifiedBoundingBox;
const visibleAabb = Rectangle.translated(
unifiedBoundingBox,
this.entity.position
);
this.visibleAabb = visibleAabb;
this.scheduledBoundingBoxUpdate = false;
}
}

3
packages/timing/traits/animated.trait.js
View File

@ -164,9 +164,8 @@ class AnimatedBase extends Trait {
return [0, 0, 0, 0];
}
const viewPosition = this.offsetFor(key);
const position = Vector.add(this.entity.position, viewPosition);
const size = animation.frameSize;
const rectangle = Rectangle.compose(position, size);
const rectangle = Rectangle.compose(viewPosition, size);
const expanded = Rectangle.expand(
rectangle,
Vector.sub(Vector.mul(size, this.entity.rawVisibleScale), size),