From e97aef03d17f7746804dd9783845bbf9bdb71634 Mon Sep 17 00:00:00 2001 From: cha0s Date: Thu, 16 May 2019 19:30:51 -0500 Subject: [PATCH] fix: removing nonexistent events is ok --- packages/core/event-emitter.js | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/packages/core/event-emitter.js b/packages/core/event-emitter.js index 3fe2d1d..f65a230 100644 --- a/packages/core/event-emitter.js +++ b/packages/core/event-emitter.js @@ -77,12 +77,10 @@ export function EventEmitterMixin(Superclass) { return; } // Function. - const lists = []; - if ((type in this.$$events)) { - lists.push(this.$$events); + if (!(type in this.$$events)) { + return; } - const listeners = this.$$events; - listeners[type] = listeners[type].filter((listener) => { + this.$$events[type] = this.$$events[type].filter((listener) => { return listener.fn !== fn; }); }