cha0s/avocado-old
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor: simplify flow

Browse Source
This commit is contained in:
cha0s 2019-09-08 19:31:14 -05:00
parent b591e5b08f
commit f6a461d2d5
1 changed files with 3 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
packages/behavior/item/actions.js
View File

@ -70,16 +70,10 @@ export class Actions extends decorate(Traversals) {
} }
parallel(context) { parallel(context) {
let immediate = true;
const results = this.traversals.map((traversal) => { const results = this.traversals.map((traversal) => {
const result = traversal.traverse(context); return traversal.traverse(context);
// Side-effect for performance.
if (result instanceof Promise) {
immediate = false;
}
return result;
}); });
return immediate ? results : TickingPromise.all(results); return TickingPromise.all(results);
} }
prologue() { prologue() {
@ -90,12 +84,7 @@ export class Actions extends decorate(Traversals) {
} }
serial(context) { serial(context) {
// Immediate tick. Maybe we can avoid a promise? return this.tickingPromise(context);
this.tick(context, 0);
// If it's pending, we have to return a ticking promise.
if (this.pending) {
return this.tickingPromise(context);
}
} }
tickingPromise(context) { tickingPromise(context) {