From fb19cdfc696a350ed7dc051249281667d5cb0837 Mon Sep 17 00:00:00 2001
From: cha0s <git@cha0s.io>
Date: Tue, 19 Mar 2019 11:29:07 -0500
Subject: [PATCH] refactor: frame rect calc

---
 packages/entity/traits/animated.js | 21 +++++++++------------
 1 file changed, 9 insertions(+), 12 deletions(-)

diff --git a/packages/entity/traits/animated.js b/packages/entity/traits/animated.js
index 3330adc..836ecb6 100644
--- a/packages/entity/traits/animated.js
+++ b/packages/entity/traits/animated.js
@@ -37,16 +37,6 @@ class AnimatedBase extends Trait {
     this.loadSpriteImageIfPossible();
   }
 
-  get frameRect() {
-    const direction = ('direction' in this.entity) ? this.entity.direction : 0;
-    return [
-      this.entity.currentFrame * this.frameSize[0],
-      direction * this.frameSize[1],
-      this.frameSize[0],
-      this.frameSize[1],
-    ];
-  }
-
   loadSpriteImageIfPossible() {
     if (!this.entity.container) {
       return;
@@ -62,9 +52,16 @@ class AnimatedBase extends Trait {
   }
 
   updateFrameRect() {
-    if (this.sprite) {
-      this.sprite.sourceRectangle = this.frameRect;
+    if (!this.sprite) {
+      return;
     }
+    const direction = ('direction' in this.entity) ? this.entity.direction : 0;
+    this.sprite.sourceRectangle = [
+      this.entity.currentFrame * this.frameSize[0],
+      direction * this.frameSize[1],
+      this.frameSize[0],
+      this.frameSize[1],
+    ];
   }
 
   listeners() {