From 38a780759ad21173db76e29b6d98ba5b4b93815e Mon Sep 17 00:00:00 2001
From: cha0s <git@cha0s.io>
Date: Mon, 29 Mar 2021 10:39:22 -0500
Subject: [PATCH] refactor: optimize ticking

---
 packages/entity/src/resources/entity-list.js | 9 +++++++--
 packages/entity/src/resources/entity.js      | 4 ++++
 2 files changed, 11 insertions(+), 2 deletions(-)

diff --git a/packages/entity/src/resources/entity-list.js b/packages/entity/src/resources/entity-list.js
index c67949b..f102736 100644
--- a/packages/entity/src/resources/entity-list.js
+++ b/packages/entity/src/resources/entity-list.js
@@ -41,7 +41,9 @@ export default (latus) => {
       }
       this.#entities[uuid] = entity;
       this.#flatEntities.push(entity);
-      this.#entityTickers.push(entity.tick);
+      if (entity.hasTickers()) {
+        this.#entityTickers.push(entity.tick);
+      }
       // eslint-disable-next-line no-param-reassign
       entity.list = this;
       entity.emit('addedToList');
@@ -176,7 +178,10 @@ export default (latus) => {
       entity.emit('removedFromList', this);
       delete this.#entities[uuid];
       this.#flatEntities.splice(this.#flatEntities.indexOf(entity), 1);
-      this.#entityTickers.splice(this.#entityTickers.indexOf(entity.tick), 1);
+      const index = this.#entityTickers.indexOf(entity.tick);
+      if (-1 !== index) {
+        this.#entityTickers.splice(index, 1);
+      }
       this.emit('entityRemoved', entity);
     }
 
diff --git a/packages/entity/src/resources/entity.js b/packages/entity/src/resources/entity.js
index 4f3501f..22c73be 100644
--- a/packages/entity/src/resources/entity.js
+++ b/packages/entity/src/resources/entity.js
@@ -211,6 +211,10 @@ export default (latus) => {
       this.emit('destroyed');
     }
 
+    hasTickers() {
+      return this.#traitTickers.length;
+    }
+
     invokeHook(hook, ...args) {
       const results = {};
       if (!(hook in this.#hooks)) {