From 572832b0372389db9458298eaf691e77e6a2606e Mon Sep 17 00:00:00 2001 From: cha0s Date: Fri, 1 Dec 2023 05:34:44 -0600 Subject: [PATCH] fix: signal propagation --- packages/web/src/server/index.js | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/packages/web/src/server/index.js b/packages/web/src/server/index.js index d2fdbd4..537002e 100644 --- a/packages/web/src/server/index.js +++ b/packages/web/src/server/index.js @@ -83,12 +83,15 @@ export const hooks = { } // Otherwise, spawn `webpack-dev-server` (WDS). const cmd = [ - 'npx', 'webpack', 'serve', + // `npx` doesn't propagate signals! + // 'npx', 'webpack', + join(FLECKS_CORE_ROOT, 'node_modules', '.bin', 'webpack'), + 'serve', '--mode', 'development', '--hot', '--config', flecks.buildConfig('fleckspack.config.js'), ]; - spawnWith( + const child = spawnWith( cmd, { env: { @@ -96,6 +99,10 @@ export const hooks = { }, }, ); + // Clean up on exit. + process.on('exit', () => { + child.kill(); + }); // Remove the build config since we're handing off to WDS. // eslint-disable-next-line no-param-reassign delete configs.web;