cha0s/flecks
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor: throw error on bad hook type

Browse Source
This commit is contained in:
cha0s 2024-01-27 15:41:07 -06:00
parent 9208fe7fe9
commit 86750558e6
1 changed files with 18 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
packages/core/build/flecks.js
View File

@ -869,14 +869,19 @@ exports.Flecks = class Flecks {
debugSilly('registering %s...', fleck); debugSilly('registering %s...', fleck);
this.flecks[fleck] = M; this.flecks[fleck] = M;
if (M.hooks) { if (M.hooks) {
const keys = Object.keys(M.hooks); const hooks = Object.keys(M.hooks);
debugSilly("hooks for '%s': %O", fleck, keys); debugSilly("hooks for '%s': %O", fleck, hooks);
for (let j = 0; j < keys.length; j++) { for (let j = 0; j < hooks.length; j++) {
const key = keys[j]; const hook = hooks[j];
if (!this.hooks[key]) { if (!this.hooks[hook]) {
this.hooks[key] = []; this.hooks[hook] = [];
} }
this.hooks[key].push({fleck, fn: M.hooks[key]}); if ('function' !== typeof M.hooks[hook]) {
throw new TypeError(
`Hook implementation must be a function! ('${fleck}' implementing '${hook}')`,
);
}
this.hooks[hook].push({fleck, fn: M.hooks[hook]});
} }
} }
} }
@ -897,13 +902,13 @@ exports.Flecks = class Flecks {
* @param {*} fleck * @param {*} fleck
*/ */
unregisterFleckHooks(fleck) { unregisterFleckHooks(fleck) {
const keys = Object.keys(this.hooks); const hooks = Object.keys(this.hooks);
for (let j = 0; j < keys.length; j++) { for (let j = 0; j < hooks.length; j++) {
const key = keys[j]; const hook = hooks[j];
if (this.hooks[key]) { if (this.hooks[hook]) {
const index = this.hooks[key].findIndex(({fleck: hookPlugin}) => hookPlugin === fleck); const index = this.hooks[hook].findIndex(({fleck: hookPlugin}) => hookPlugin === fleck);
if (-1 !== index) { if (-1 !== index) {
this.hooks[key].splice(index, 1); this.hooks[hook].splice(index, 1);
} }
} }
} }