From 75da3ad9d4b37f9b289d5b2c492e202a54785a4b Mon Sep 17 00:00:00 2001 From: cha0s Date: Thu, 28 Mar 2019 13:07:24 -0500 Subject: [PATCH] chore: old junk --- common-mistakes.md | 34 ---------------------------------- 1 file changed, 34 deletions(-) diff --git a/common-mistakes.md b/common-mistakes.md index b4028c8..e69de29 100644 --- a/common-mistakes.md +++ b/common-mistakes.md @@ -1,34 +0,0 @@ -``` -webpack:///../lib/@avocado/packages/entity/trait.js?:29 - entity.on("".concat(type, ".trait-").concat(traitType), listeners[type], this); -``` - -This is because you subclassed `Trait` but forgot to pass through the arguments -from your subclass constructor to the superclass constructor. Always default -to writing your Trait definition like: - -``` -class MyTrait extends Trait { - - initialize() { - // ... - } - -} -``` - -All trait initialization should be done in `initialize`. - -If you need really need to access arguments in your subclass constructor, opt -to pass along `arguments` instead, such as: - -``` -class MyTrait extends Trait { - - constructor(entity, params, state) { - super(...arguments); - // ... - } - -} -```