From 0c8ec0b1d220d5c777c57d8d1156c8a15b522d20 Mon Sep 17 00:00:00 2001
From: cha0s <git@cha0s.io>
Date: Sun, 21 Jun 2020 00:50:33 -0500
Subject: [PATCH] refactor: type rendering

---
 src/client/components/persea.jsx              |  21 +++-
 src/client/components/traits.jsx              |  35 ++----
 .../types/actions.type-renderer.jsx           |  11 +-
 .../components/types/condition.raw.scss       |   2 +-
 .../types/condition.type-renderer.jsx         |   9 +-
 src/client/components/types/literal.raw.scss  |   9 ++
 .../types/literal.type-renderer.jsx           |  58 ++++++++++
 .../components/types/property-prop-types.js   |   2 +
 .../types/routines.type-renderer.jsx          |   2 +-
 src/client/components/types/steps.jsx         | 105 ------------------
 .../{steps.raw.scss => traversal.raw.scss}    |   2 +-
 .../types/traversal.type-renderer.jsx         |  96 ++++++++++++++++
 src/client/components/types/typing.js         |  58 ++++++----
 src/client/components/types/value.raw.scss    |   9 --
 .../components/types/value.type-renderer.jsx  |  80 ++++---------
 src/client/context/typeRenderers.js           |   3 +
 src/client/hooks/useTypeRenderers.js          |   5 +
 .../types => }/type-renderers.scwp.js         |   0
 18 files changed, 264 insertions(+), 243 deletions(-)
 create mode 100644 src/client/components/types/literal.raw.scss
 create mode 100644 src/client/components/types/literal.type-renderer.jsx
 delete mode 100644 src/client/components/types/steps.jsx
 rename src/client/components/types/{steps.raw.scss => traversal.raw.scss} (97%)
 create mode 100644 src/client/components/types/traversal.type-renderer.jsx
 create mode 100644 src/client/context/typeRenderers.js
 create mode 100644 src/client/hooks/useTypeRenderers.js
 rename src/client/{components/types => }/type-renderers.scwp.js (100%)

diff --git a/src/client/components/persea.jsx b/src/client/components/persea.jsx
index f260613..4a1d6d8 100644
--- a/src/client/components/persea.jsx
+++ b/src/client/components/persea.jsx
@@ -1,10 +1,23 @@
 import {hot} from 'react-hot-loader';
-import React from 'react';
+import React, {useState} from 'react';
+
+import TypeRenderersContext from '~/client/context/typeRenderers';
+import {all as allTypeRenderers} from '~/client/type-renderers.scwp';
 
 import Entity from './entity';
 
-const Persea = () => (
-  <Entity />
-);
+const typeRenderMap = () => Object.values(allTypeRenderers()).reduce((r, M) => {
+  const {default: {type, Component}} = M;
+  return {...r, [type]: Component};
+}, {});
+
+const Persea = () => {
+  const [typeRenderers] = useState(typeRenderMap());
+  return (
+    <TypeRenderersContext.Provider value={typeRenderers}>
+      <Entity />
+    </TypeRenderersContext.Provider>
+  );
+};
 
 export default hot(module)(Persea);
diff --git a/src/client/components/traits.jsx b/src/client/components/traits.jsx
index d908dd4..57d452f 100644
--- a/src/client/components/traits.jsx
+++ b/src/client/components/traits.jsx
@@ -15,7 +15,7 @@ import {
 import {createSelector} from '@reduxjs/toolkit';
 import {deregisterHooks, registerHooks} from 'scwp';
 
-import {all as allTypeRenderers} from './types/type-renderers.scwp';
+import Value from './types/value.type-renderer';
 
 const SCROLL_MAG = 80;
 
@@ -43,20 +43,10 @@ const ensureTraitComponents = () => {
     }, {});
   }
 };
-let TypeRenderers;
-const ensureTypeRenderers = () => {
-  if (!TypeRenderers) {
-    TypeRenderers = Object.values(allTypeRenderers()).reduce((r, M) => {
-      const {default: {type, Component}} = M;
-      return {...r, [type]: Component};
-    }, {});
-  }
-};
 
 const makeTabSelector = (context, type) => createSelector(
   (_) => _,
   (trait) => {
-    ensureTypeRenderers();
     ensureTraitComponents();
     const {params: paramsRaw, state: stateRaw} = trait;
     const {[type]: TraitComponent} = TraitComponents;
@@ -68,27 +58,19 @@ const makeTabSelector = (context, type) => createSelector(
     const renderComponents = (description, values) => (
       // eslint-disable-next-line no-shadow
       Object.values(mapObject(description, (description, key) => {
-        const {label, options, type: componentType} = description;
-        const Component = TypeRenderers[componentType];
+        const {label, options} = description;
         return (
-          <label>
+          <label key={key}>
             <span className="text">
               {label}
               :
             </span>
             <div className="invisible-separator" />
-            {
-              Component
-                ? (
-                  <Component
-                    context={context}
-                    key={key}
-                    options={options}
-                    value={values[key]}
-                  />
-                )
-                : <div className="unrenderable" title="No renderer found!">?</div>
-            }
+            <Value.Component
+              context={context}
+              options={options}
+              value={values[key]}
+            />
           </label>
         );
       }))
@@ -187,6 +169,7 @@ const Traits = (props) => {
 };
 
 Traits.propTypes = {
+  context: PropTypes.shape({}).isRequired,
   traits: PropTypes.shape({}).isRequired,
 };
 
diff --git a/src/client/components/types/actions.type-renderer.jsx b/src/client/components/types/actions.type-renderer.jsx
index 2a39f4a..fc97c31 100644
--- a/src/client/components/types/actions.type-renderer.jsx
+++ b/src/client/components/types/actions.type-renderer.jsx
@@ -19,13 +19,10 @@ const Actions = ({
       {
         value && value.traversals.length > 0 && (
           value.traversals.map(
-            (traversal) => (
-              <li>
-                <Value.Component
-                  context={context}
-                  type="any"
-                  value={traversal}
-                />
+            (traversal, i) => (
+              // eslint-disable-next-line react/no-array-index-key
+              <li key={i}>
+                <Value.Component context={context} value={traversal} />
               </li>
             ),
           )
diff --git a/src/client/components/types/condition.raw.scss b/src/client/components/types/condition.raw.scss
index 1ea66cf..ee7402c 100644
--- a/src/client/components/types/condition.raw.scss
+++ b/src/client/components/types/condition.raw.scss
@@ -11,6 +11,6 @@
   text-align-last: center;
 }
 
-.operand .steps {
+.operand .traversal {
   display: flex;
 }
diff --git a/src/client/components/types/condition.type-renderer.jsx b/src/client/components/types/condition.type-renderer.jsx
index 480217d..f86fe4f 100644
--- a/src/client/components/types/condition.type-renderer.jsx
+++ b/src/client/components/types/condition.type-renderer.jsx
@@ -6,9 +6,9 @@ import React from 'react';
 import propertyPropTypes from './property-prop-types';
 import Value from './value.type-renderer';
 
-const renderOperand = (context, operand, type) => (
+const renderOperand = (context, operand) => (
   <span className="operand">
-    <Value.Component context={context} type={type} value={operand} />
+    <Value.Component context={context} value={operand} />
   </span>
 );
 
@@ -39,7 +39,6 @@ const Condition = ({
           case '>=':
           case '<':
           case '<=': {
-            const type = -1 !== ['is', 'isnt'].indexOf(value.operator) ? 'any' : 'number';
             return value.operands.slice(1).reduce(
               (r, operand) => (
                 <>
@@ -47,10 +46,10 @@ const Condition = ({
                   <select className="operator" readOnly value={value.operator}>
                     {binaryOps.map(([k, v]) => <option value={k}>{v}</option>)}
                   </select>
-                  {renderOperand(context, operand, type)}
+                  {renderOperand(context, operand)}
                 </>
               ),
-              renderOperand(context, value.operands[0], type),
+              renderOperand(context, value.operands[0]),
             );
           }
           default:
diff --git a/src/client/components/types/literal.raw.scss b/src/client/components/types/literal.raw.scss
new file mode 100644
index 0000000..ca3859d
--- /dev/null
+++ b/src/client/components/types/literal.raw.scss
@@ -0,0 +1,9 @@
+
+:scope {
+  display: flex;
+  align-items: center;
+}
+
+select {
+  margin-right: 0.25em;
+}
diff --git a/src/client/components/types/literal.type-renderer.jsx b/src/client/components/types/literal.type-renderer.jsx
new file mode 100644
index 0000000..84826c4
--- /dev/null
+++ b/src/client/components/types/literal.type-renderer.jsx
@@ -0,0 +1,58 @@
+import {compose} from '@avocado/core';
+import contempo from 'contempo';
+import React from 'react';
+
+import useTypeRenderers from '~/client/hooks/useTypeRenderers';
+
+import propertyPropTypes from './property-prop-types';
+import {contextStepsList} from './steps-lists';
+import {typeFromLiteral} from './typing';
+
+const decorate = compose(
+  contempo(require('./literal.raw.scss')),
+);
+
+const Literal = ({
+  context,
+  value,
+}) => {
+  const typeRenderers = useTypeRenderers();
+  const type = typeFromLiteral(value.value);
+  const stepsList = contextStepsList(context, type);
+  const tierOptions = Object.keys(stepsList.reduce((r, optionSteps) => {
+    if (!optionSteps[0] || !optionSteps[0].key) {
+      return r;
+    }
+    return {...r, [optionSteps[0].key]: true};
+  }, {}));
+  tierOptions.splice(tierOptions.indexOf('context'), 1);
+  tierOptions.push('<literal>');
+  return (
+    <div className="literal">
+      <select readOnly value="<literal>">
+        {
+          tierOptions
+            .sort((l, r) => (l.toLowerCase() < r.toLowerCase() ? -1 : 1))
+            .map((tierOption) => <option key={tierOption}>{tierOption}</option>)
+        }
+      </select>
+      {
+        (() => {
+          const Component = typeRenderers[type];
+          return Component
+            ? <Component value={value.value} />
+            : null;
+        })()
+      }
+    </div>
+  );
+};
+
+Literal.propTypes = {
+  ...propertyPropTypes,
+};
+
+export default {
+  type: 'literal',
+  Component: decorate(Literal),
+};
diff --git a/src/client/components/types/property-prop-types.js b/src/client/components/types/property-prop-types.js
index 4fae0dc..89a686f 100644
--- a/src/client/components/types/property-prop-types.js
+++ b/src/client/components/types/property-prop-types.js
@@ -1,5 +1,7 @@
 import PropTypes from 'prop-types';
 
 export default {
+  context: PropTypes.shape({}),
   options: PropTypes.shape({}),
+  value: PropTypes.any,
 };
diff --git a/src/client/components/types/routines.type-renderer.jsx b/src/client/components/types/routines.type-renderer.jsx
index f50e783..70fa18e 100644
--- a/src/client/components/types/routines.type-renderer.jsx
+++ b/src/client/components/types/routines.type-renderer.jsx
@@ -22,7 +22,7 @@ const Routines = ({
           entries.length > 0 && (
             entries.map(
               ([name, routine]) => (
-                <li className="routine">
+                <li className="routine" key={name}>
                   <label>
                     <span className="text">{name}</span>
                     <Actions.Component context={context} value={routine.routine} />
diff --git a/src/client/components/types/steps.jsx b/src/client/components/types/steps.jsx
deleted file mode 100644
index 2a834cd..0000000
--- a/src/client/components/types/steps.jsx
+++ /dev/null
@@ -1,105 +0,0 @@
-import {compose} from '@avocado/core';
-import contempo from 'contempo';
-import React from 'react';
-
-import {contextStepsList} from './steps-lists';
-import {typeFromSteps, typeFromLiteral} from './typing';
-import Value from './value.type-renderer';
-
-const decorate = compose(
-  contempo(require('./steps.raw.scss')),
-);
-
-const Steps = (props) => {
-  const {
-    context,
-    steps,
-    type,
-    value,
-  } = props;
-  let stepsType;
-  if ('undefined' === typeof value) {
-    stepsType = type;
-  }
-  else if (value.steps) {
-    stepsType = typeFromSteps(context, value.steps);
-  }
-  else {
-    stepsType = typeFromLiteral(value);
-  }
-  const stepsList = contextStepsList(context, stepsType);
-  return (
-    <div className="steps">
-      {steps.map((step, i) => {
-        switch (step.type) {
-          case 'key': {
-            const tierOptions = Object.keys(stepsList.reduce((r, optionSteps) => {
-              if (!optionSteps[i] || !optionSteps[i].key) {
-                return r;
-              }
-              for (let j = 0; j < i; ++j) {
-                if (steps[j].key !== optionSteps[j].key) {
-                  return r;
-                }
-              }
-              return {...r, [optionSteps[i].key]: true};
-            }, {}));
-            if (0 === i) {
-              tierOptions.push('<literal>');
-            }
-            return (
-              <span className="key">
-                <select readOnly value={steps[i].key}>
-                  {
-                    tierOptions
-                      .sort((l, r) => (l.toLowerCase() < r.toLowerCase() ? -1 : 1))
-                      .map((tierOption) => <option>{tierOption}</option>)
-                  }
-                </select>
-              </span>
-            );
-          }
-          case 'invoke':
-            return (
-              <div className="invoke">
-                <span className="paren open">(</span>
-                {step.args.map((arg) => (
-                  <div className="arg">
-                    <label>
-                      {arg.label}
-                      <Value.Component
-                        context={context}
-                        type={
-                          arg.steps
-                            ? typeFromSteps(context, arg.steps)
-                            : typeFromLiteral(arg)
-                        }
-                        value={arg}
-                      />
-                    </label>
-                  </div>
-                ))}
-                <span className="paren close">)</span>
-              </div>
-            );
-          default:
-            return null;
-        }
-      })}
-      {
-        value && (
-          <span className="assign">
-            <span className="op">=</span>
-            <Value.Component
-              context={context}
-              type={typeFromSteps(context, steps)}
-              value={value}
-            />
-          </span>
-        )
-      }
-    </div>
-  );
-};
-
-export default decorate(Steps);
diff --git a/src/client/components/types/steps.raw.scss b/src/client/components/types/traversal.raw.scss
similarity index 97%
rename from src/client/components/types/steps.raw.scss
rename to src/client/components/types/traversal.raw.scss
index 16415d2..148dd0d 100644
--- a/src/client/components/types/steps.raw.scss
+++ b/src/client/components/types/traversal.raw.scss
@@ -37,7 +37,7 @@
   padding: 0.5em;
 }
 
-.arg .steps {
+.arg .traversal {
   display: flex;
 }
 
diff --git a/src/client/components/types/traversal.type-renderer.jsx b/src/client/components/types/traversal.type-renderer.jsx
new file mode 100644
index 0000000..ea7572f
--- /dev/null
+++ b/src/client/components/types/traversal.type-renderer.jsx
@@ -0,0 +1,96 @@
+import {compose} from '@avocado/core';
+import contempo from 'contempo';
+import React from 'react';
+
+import propertyPropTypes from './property-prop-types';
+import {contextStepsList} from './steps-lists';
+import {typeFromSteps} from './typing';
+import Value from './value.type-renderer';
+
+const decorate = compose(
+  contempo(require('./traversal.raw.scss')),
+);
+
+const Traversal = (props) => {
+  const {
+    context,
+    value: {steps, value},
+  } = props;
+  const stepsList = contextStepsList(context, typeFromSteps(context, steps));
+  return (
+    <div className="traversal">
+      {steps.map((step, i) => (
+        // eslint-disable-next-line react/no-array-index-key
+        <span className="step" key={i}>
+          {
+            (() => {
+              switch (step.type) {
+                case 'key': {
+                  const tierOptions = Object.keys(stepsList.reduce((r, optionSteps) => {
+                    if (!optionSteps[i] || !optionSteps[i].key) {
+                      return r;
+                    }
+                    for (let j = 0; j < i; ++j) {
+                      if (steps[j].key !== optionSteps[j].key) {
+                        return r;
+                      }
+                    }
+                    return {...r, [optionSteps[i].key]: true};
+                  }, {}));
+                  if (0 === i) {
+                    tierOptions.push('<literal>');
+                  }
+                  return (
+                    <span className="key">
+                      <select readOnly value={steps[i].key}>
+                        {
+                          tierOptions
+                            .sort((l, r) => (l.toLowerCase() < r.toLowerCase() ? -1 : 1))
+                            .map((tierOption) => <option key={tierOption}>{tierOption}</option>)
+                        }
+                      </select>
+                    </span>
+                  );
+                }
+                case 'invoke':
+                  return (
+                    <div className="invoke">
+                      <span className="paren open">(</span>
+                      {step.args.map((arg) => (
+                        <div className="arg" key={JSON.stringify(arg)}>
+                          <label>
+                            {arg.label}
+                            <Value.Component context={context} value={arg} />
+                          </label>
+                        </div>
+                      ))}
+                      <span className="paren close">)</span>
+                    </div>
+                  );
+                default:
+                  return null;
+              }
+            })()
+          }
+        </span>
+      ))}
+      {
+        value && (
+          <span className="assign">
+            <span className="op">=</span>
+            <Value.Component context={context} value={value} />
+          </span>
+        )
+      }
+    </div>
+  );
+};
+
+Traversal.propTypes = {
+  ...propertyPropTypes,
+};
+
+export default {
+  type: 'traversal',
+  Component: decorate(Traversal),
+};
diff --git a/src/client/components/types/typing.js b/src/client/components/types/typing.js
index 86f2ea0..7427061 100644
--- a/src/client/components/types/typing.js
+++ b/src/client/components/types/typing.js
@@ -1,33 +1,45 @@
 import {Context} from '@avocado/behavior';
 
-export function typeFromLiteral(v) {
-  if ('literal' === v.type) {
-    const {value} = v;
-    if ('undefined' === typeof value) {
-      return 'undefined';
-    }
-    if (null === value) {
-      return 'null';
-    }
-    if ('number' === typeof value) {
-      return 'number';
-    }
-    if ('string' === typeof value) {
-      return 'string';
-    }
-    if ('boolean' === typeof value) {
-      return 'bool';
-    }
-    if (value.length && 2 === value.length && value instanceof Array) {
-      return 'vector';
-    }
+export function typeFromLiteral(value) {
+  if ('undefined' === typeof value) {
+    return 'undefined';
   }
-  if ('actions' === v.type && v.traversals) {
-    return 'actions';
+  if (null === value) {
+    return 'null';
+  }
+  if ('number' === typeof value) {
+    return 'number';
+  }
+  if ('string' === typeof value) {
+    return 'string';
+  }
+  if ('boolean' === typeof value) {
+    return 'bool';
+  }
+  if (value.length && 2 === value.length && value instanceof Array) {
+    return 'vector';
   }
   return 'object';
 }
 
+export function typeFromValue(v) {
+  if ('object' === typeof v) {
+    if ('routines' === v.type) {
+      return 'routines';
+    }
+    if ('traversal' === v.type) {
+      return 'traversal';
+    }
+    if ('actions' === v.type && v.traversals) {
+      return 'actions';
+    }
+    if ('literal' === v.type) {
+      return 'literal';
+    }
+  }
+  return undefined;
+}
+
 export function typeFromSteps(context, steps) {
   if (!steps || 0 === steps.length) {
     return 'undefined';
diff --git a/src/client/components/types/value.raw.scss b/src/client/components/types/value.raw.scss
index f17d327..e9cef05 100644
--- a/src/client/components/types/value.raw.scss
+++ b/src/client/components/types/value.raw.scss
@@ -1,12 +1,3 @@
 .fn {
   text-align-last: right;
 }
-
-.literal {
-  display: flex;
-  align-items: center;
-}
-
-.literal select {
-  margin-right: 0.25em;
-}
diff --git a/src/client/components/types/value.type-renderer.jsx b/src/client/components/types/value.type-renderer.jsx
index 03d3e3f..ccb969d 100644
--- a/src/client/components/types/value.type-renderer.jsx
+++ b/src/client/components/types/value.type-renderer.jsx
@@ -3,66 +3,10 @@ import contempo from 'contempo';
 import PropTypes from 'prop-types';
 import React from 'react';
 
+import useTypeRenderers from '~/client/hooks/useTypeRenderers';
+import {typeFromLiteral, typeFromValue} from '~/client/components/types/typing';
+
 import propertyPropTypes from './property-prop-types';
-import Steps from './steps';
-import {contextStepsList} from './steps-lists';
-import {typeFromLiteral} from './typing';
-
-let TypeRenderers;
-const ensureTypeRenderers = () => {
-  if (!TypeRenderers) {
-    const {all: allTypeRenderers} = require('./type-renderers.scwp');
-    TypeRenderers = Object.values(allTypeRenderers()).reduce((r, M) => {
-      const {default: {type, Component}} = M;
-      return {...r, [type]: Component};
-    }, {});
-  }
-};
-
-const renderValue = (context, type, value) => {
-  ensureTypeRenderers();
-  switch (value.type) {
-    case 'traversal': {
-      return <Steps context={context} steps={value.steps} type={type} value={value.value} />;
-    }
-    case 'actions': {
-      const Component = TypeRenderers.actions;
-      return <Component context={context} value={value} />;
-    }
-    case 'literal': {
-      const stepsList = contextStepsList(context, type);
-      const tierOptions = Object.keys(stepsList.reduce((r, optionSteps) => {
-        if (!optionSteps[0] || !optionSteps[0].key) {
-          return r;
-        }
-        return {...r, [optionSteps[0].key]: true};
-      }, {}));
-      tierOptions.splice(tierOptions.indexOf('context'), 1);
-      tierOptions.push('<literal>');
-      return (
-        <div className="literal">
-          <select readOnly value="<literal>">
-            {
-              tierOptions
-                .sort((l, r) => (l.toLowerCase() < r.toLowerCase() ? -1 : 1))
-                .map((tierOption) => <option>{tierOption}</option>)
-            }
-          </select>
-          {
-            (() => {
-              const Component = TypeRenderers['any' === type ? typeFromLiteral(value) : type];
-              return Component
-                ? <Component value={value.value} />
-                : null;
-            })()
-          }
-        </div>
-      );
-    }
-    default:
-      return null;
-  }
-};
 
 const decorate = compose(
   contempo(require('./value.raw.scss')),
@@ -70,9 +14,23 @@ const decorate = compose(
 
 const Value = ({
   context,
-  type,
+  options,
   value,
-}) => <span className="value">{renderValue(context, type, value)}</span>;
+}) => {
+  const typeRenderers = useTypeRenderers();
+  const fromValue = typeFromValue(value);
+  const type = 'undefined' !== typeof fromValue ? fromValue : typeFromLiteral(value);
+  const Component = typeRenderers[type];
+  return (
+    <span className="value">
+      {
+        Component
+          ? <Component context={context} options={options} value={value} />
+          : <div className="unrenderable" title={`No renderer for '${type}' found!`}>?</div>
+      }
+    </span>
+  );
+};
 
 Value.propTypes = {
   ...propertyPropTypes,
diff --git a/src/client/context/typeRenderers.js b/src/client/context/typeRenderers.js
new file mode 100644
index 0000000..d635f62
--- /dev/null
+++ b/src/client/context/typeRenderers.js
@@ -0,0 +1,3 @@
+import {createContext} from 'react';
+
+export default createContext({});
diff --git a/src/client/hooks/useTypeRenderers.js b/src/client/hooks/useTypeRenderers.js
new file mode 100644
index 0000000..aac282a
--- /dev/null
+++ b/src/client/hooks/useTypeRenderers.js
@@ -0,0 +1,5 @@
+import {useContext} from 'react';
+
+import TypeRenderersContext from '~/client/context/typeRenderers';
+
+export default () => useContext(TypeRenderersContext);
diff --git a/src/client/components/types/type-renderers.scwp.js b/src/client/type-renderers.scwp.js
similarity index 100%
rename from src/client/components/types/type-renderers.scwp.js
rename to src/client/type-renderers.scwp.js