refactor: no onIncrement

src/client/types/bool.type-renderer.jsx

@@ -6,7 +6,7 @@ import propTypes from './prop-types';
 const Bool = ({
   dispatchers: {
     onChange = () => {},
-  },
+  } = {},
   value,
 }) => (
   <select onChange={(event) => onChange(!!event.target.value, event)} value={value ? '1' : ''}>

src/client/types/condition.type-renderer.jsx

@@ -49,11 +49,6 @@ const Condition = ({
           : {operands: mergeToOperand(index, newValue)},
       );
     },
-    onIncrement: (operandValue) => {
-      onChange({
-        operands: mergeToOperand(index, operands[index].value + operandValue),
-      });
-    },
   });
   return (
     <span className="condition">

src/client/types/number.type-renderer.jsx

@@ -1,7 +1,7 @@
 import {compose} from '@avocado/core';
 import contempo from 'contempo';
 import PropTypes from 'prop-types';
-import React from 'react';
+import React, {useRef} from 'react';
 
 import propTypes from './prop-types';
 
@@ -12,54 +12,57 @@ const decorate = compose(
 const Number = ({
   dispatchers: {
     onChange = () => {},
-    onIncrement = () => {},
-  },
+  } = {},
   options,
   value,
-}) => (
-  <span className="number">
-    {
-      options
-        ? (
-          <select onChange={(event) => onChange(event.target.value, event)} value={value}>
-            {Object.entries(options).map(([optionValue, optionLabel]) => (
-              <option key={optionValue}>{optionLabel}</option>
-            ))}
-          </select>
-        )
-        : (
-          <>
-            <input
-              onChange={(event) => {
-                const {value: number} = event.target;
-                // eslint-disable-next-line no-restricted-globals
-                if (!isNaN(number)) {
-                  onChange('' === number ? 0 : parseInt(number, 10), event);
-                }
-              }}
-              // onWheel={(e) => (e.preventDefault(), false)}
-              type="text"
-              value={value}
-            />
-            <div className="controls">
-              <button
-                onClick={(event) => onIncrement(1, event)}
-                type="button"
-              >
-                +
-              </button>
-              <button
-                onClick={(event) => onIncrement(-1, event)}
-                type="button"
-              >
-                -
-              </button>
-            </div>
-          </>
-        )
-    }
-  </span>
-);
+}) => {
+  const inputRef = useRef(null);
+  return (
+    <span className="number">
+      {
+        options
+          ? (
+            <select onChange={(event) => onChange(event.target.value, event)} value={value}>
+              {Object.entries(options).map(([optionValue, optionLabel]) => (
+                <option key={optionValue}>{optionLabel}</option>
+              ))}
+            </select>
+          )
+          : (
+            <>
+              <input
+                onChange={(event) => {
+                  const {value: number} = event.target;
+                  // eslint-disable-next-line no-restricted-globals
+                  if (!isNaN(number)) {
+                    onChange('' === number ? 0 : parseInt(number, 10), event);
+                  }
+                }}
+                // onWheel={(e) => (e.preventDefault(), false)}
+                ref={inputRef}
+                type="text"
+                value={value}
+              />
+              <div className="controls">
+                <button
+                  onClick={(event) => onChange(1 + parseInt(inputRef.current.value, 10), event)}
+                  type="button"
+                >
+                  +
+                </button>
+                <button
+                  onClick={(event) => onChange(-1 + parseInt(inputRef.current.value, 10), event)}
+                  type="button"
+                >
+                  -
+                </button>
+              </div>
+            </>
+          )
+      }
+    </span>
+  );
+};
 
 Number.propTypes = {
   ...propTypes,

src/client/types/string.type-renderer.jsx

@@ -6,7 +6,7 @@ import propTypes from './prop-types';
 const String = ({
   dispatchers: {
     onChange = () => {},
-  },
+  } = {},
   options,
   value,
 }) => (

src/common/resources/entity/state.js

@@ -67,22 +67,6 @@ const slice = createSlice({
   name: 'entities',
   initialState: adapter.getInitialState({uris: {}}),
   reducers: {
-    incrementTraitProperty: (state, {
-      payload: {
-        target,
-        trait,
-        half,
-        key,
-        value,
-      },
-    }) => {
-      const {traits} = state.entities[target];
-      traits[trait] = traits[trait] || {};
-      traits[trait][half] = traits[trait][half] || {};
-      traits[trait][half][key] = traits[trait][half][key] || 0;
-      traits[trait][half][key] += parseFloat(value);
-      state.entities[target].traits = traits;
-    },
     setTraitProperty: (state, {
       payload: {
         target,
@@ -110,7 +94,6 @@ const slice = createSlice({
 });
 
 export const {
-  incrementTraitProperty,
   setTraitProperty,
 } = slice.actions;
 

src/common/resources/entity/trait-pane.jsx

@@ -7,7 +7,7 @@ import {useDispatch} from 'react-redux';
 
 import Value from '~/client/value';
 
-import {incrementTraitProperty, setTraitProperty} from './state';
+import {setTraitProperty} from './state';
 
 let TraitComponents;
 const ensureTraitComponents = () => {
@@ -51,7 +51,6 @@ const makeTraitPaneRenderer = (context, dispatch, target, traitType) => (trait)
             context={context}
             dispatchers={{
               onChange: (value) => dispatch(setTraitProperty({...payload, value})),
-              onIncrement: (value) => dispatch(incrementTraitProperty({...payload, value})),
             }}
             options={options}
             type={type}