From 55f8b77a986057405992f0f4e08c30bfbafdc131 Mon Sep 17 00:00:00 2001 From: cha0s Date: Mon, 14 Dec 2020 13:52:52 -0600 Subject: [PATCH] refactor: simplify --- packages/chat/src/join-channel.js | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/packages/chat/src/join-channel.js b/packages/chat/src/join-channel.js index 85a9975..aec7d2e 100644 --- a/packages/chat/src/join-channel.js +++ b/packages/chat/src/join-channel.js @@ -8,13 +8,16 @@ export default async (latus, channel, socket) => { if (!isAnonymous && !req.userId) { return; } - const [id, username] = isAnonymous - ? [0, 'anonymous'] - : [req.user.id, req.user.redditUsername]; - const users = await channelUsers(req, channel); const rendered = renderChannel(channel); - if (-1 === users.indexOf(id)) { - socket.to(rendered).send(['Join', {channel, id, username}]); + if (!isAnonymous) { + const users = await channelUsers(req, channel); + if (-1 === users.indexOf(req.user.id)) { + socket.to(rendered).send(['Join', { + channel, + id: req.user.id, + username: req.user.redditUsername, + }]); + } } await socket.join(rendered); };