From 32fa9ee257a0face6b16fbd3a43334cedebe1141 Mon Sep 17 00:00:00 2001 From: cha0s Date: Tue, 30 Jul 2024 17:05:15 -0500 Subject: [PATCH] refactor: simplify splice --- app/ecs/components/ticking.js | 22 ++++++++-------------- 1 file changed, 8 insertions(+), 14 deletions(-) diff --git a/app/ecs/components/ticking.js b/app/ecs/components/ticking.js index 6e733f6..6b9e192 100644 --- a/app/ecs/components/ticking.js +++ b/app/ecs/components/ticking.js @@ -4,29 +4,23 @@ export default class Ticking extends Component { instanceFromSchema() { return class TickingInstance extends super.instanceFromSchema() { - $$finished = []; $$tickers = []; add(ticker) { this.$$tickers.push(ticker); ticker.then(() => { - this.$$finished.push(ticker); - }); - } - - destroy() { - this.$$finished = []; - this.$$tickers = []; - } - - tick(elapsed) { - for (const ticker of this.$$finished) { this.$$tickers.splice( this.$$tickers.indexOf(ticker), 1, ); - } - this.$$finished = []; + }); + } + + destroy() { + this.$$tickers = []; + } + + tick(elapsed) { for (const ticker of this.$$tickers) { ticker.tick(elapsed); }