diff --git a/.eslintrc.cjs b/.eslintrc.cjs index 5a6925d..ff8600f 100644 --- a/.eslintrc.cjs +++ b/.eslintrc.cjs @@ -26,6 +26,9 @@ module.exports = { // Base config extends: ['eslint:recommended'], + rules: { + 'no-constant-condition': ['error', {checkLoops: false}], + }, overrides: [ // Tests diff --git a/app/ecs-components/index.js b/app/ecs-components/index.js index de1aeb4..96dde30 100644 --- a/app/ecs-components/index.js +++ b/app/ecs-components/index.js @@ -1,5 +1,4 @@ import Arbitrary from '@/ecs/arbitrary.js'; -import Base from '@/ecs/base.js'; import Schema from '@/ecs/schema.js'; import gather from '@/util/gather.js'; diff --git a/app/ecs/ecs.js b/app/ecs/ecs.js index de57d71..05a2815 100644 --- a/app/ecs/ecs.js +++ b/app/ecs/ecs.js @@ -75,7 +75,6 @@ export default class Ecs { }, next: () => { let result = it.next(); - let satisfied = false; while (!result.done) { for (const componentName of criteria) { if (!(componentName in result.value[1])) { diff --git a/app/engine.js b/app/engine.js index 3013b61..c11659c 100644 --- a/app/engine.js +++ b/app/engine.js @@ -221,10 +221,11 @@ export default class Engine { entity, payload, ] of this.incomingActions) { - const {Ecs, Controlled, id, Inventory, Position, Ticking, Wielder} = entity; + const {Controlled, Inventory, Ticking, Wielder} = entity; switch (payload.type) { case 'changeSlot': { Wielder.activeSlot = payload.value - 1; + break; } case 'moveUp': case 'moveRight': diff --git a/app/hooks/use-packet.js b/app/hooks/use-packet.js index a5ebecc..e8580c2 100644 --- a/app/hooks/use-packet.js +++ b/app/hooks/use-packet.js @@ -12,5 +12,6 @@ export default function usePacket(type, fn, dependencies) { return () => { client.removePacketListener(type, fn); }; + // eslint-disable-next-line react-hooks/exhaustive-deps }, [client, ...dependencies]); } \ No newline at end of file diff --git a/app/react-components/dom.jsx b/app/react-components/dom.jsx index 6643941..b041c7a 100644 --- a/app/react-components/dom.jsx +++ b/app/react-components/dom.jsx @@ -24,7 +24,7 @@ export default function Dom({children}) { return () => { window.removeEventListener('resize', onResize); } - }, [ref.current]); + }); return (