From 6f7ec2e7ac40adc8206cc3a80a2f417235c27335 Mon Sep 17 00:00:00 2001
From: cha0s <git@cha0s.io>
Date: Sun, 23 Jun 2024 07:35:56 -0500
Subject: [PATCH] fix: lint

---
 .eslintrc.cjs                            | 3 +++
 app/ecs-components/index.js              | 1 -
 app/ecs/ecs.js                           | 1 -
 app/engine.js                            | 3 ++-
 app/hooks/use-packet.js                  | 1 +
 app/react-components/dom.jsx             | 2 +-
 app/react-components/ecs.jsx             | 2 --
 app/routes/_main-menu.play.$.$/route.jsx | 2 +-
 app/util/script.js                       | 2 +-
 app/util/ticking-promise.test.js         | 2 +-
 10 files changed, 10 insertions(+), 9 deletions(-)

diff --git a/.eslintrc.cjs b/.eslintrc.cjs
index 5a6925d..ff8600f 100644
--- a/.eslintrc.cjs
+++ b/.eslintrc.cjs
@@ -26,6 +26,9 @@ module.exports = {
 
   // Base config
   extends: ['eslint:recommended'],
+  rules: {
+    'no-constant-condition': ['error', {checkLoops: false}],
+  },
 
   overrides: [
     // Tests
diff --git a/app/ecs-components/index.js b/app/ecs-components/index.js
index de1aeb4..96dde30 100644
--- a/app/ecs-components/index.js
+++ b/app/ecs-components/index.js
@@ -1,5 +1,4 @@
 import Arbitrary from '@/ecs/arbitrary.js';
-import Base from '@/ecs/base.js';
 import Schema from '@/ecs/schema.js';
 import gather from '@/util/gather.js';
 
diff --git a/app/ecs/ecs.js b/app/ecs/ecs.js
index de57d71..05a2815 100644
--- a/app/ecs/ecs.js
+++ b/app/ecs/ecs.js
@@ -75,7 +75,6 @@ export default class Ecs {
       },
       next: () => {
         let result = it.next();
-        let satisfied = false;
         while (!result.done) {
           for (const componentName of criteria) {
             if (!(componentName in result.value[1])) {
diff --git a/app/engine.js b/app/engine.js
index 3013b61..c11659c 100644
--- a/app/engine.js
+++ b/app/engine.js
@@ -221,10 +221,11 @@ export default class Engine {
       entity,
       payload,
     ] of this.incomingActions) {
-      const {Ecs, Controlled, id, Inventory, Position, Ticking, Wielder} = entity;
+      const {Controlled, Inventory, Ticking, Wielder} = entity;
       switch (payload.type) {
         case 'changeSlot': {
           Wielder.activeSlot = payload.value - 1;
+          break;
         }
         case 'moveUp':
         case 'moveRight':
diff --git a/app/hooks/use-packet.js b/app/hooks/use-packet.js
index a5ebecc..e8580c2 100644
--- a/app/hooks/use-packet.js
+++ b/app/hooks/use-packet.js
@@ -12,5 +12,6 @@ export default function usePacket(type, fn, dependencies) {
     return () => {
       client.removePacketListener(type, fn);
     };
+  // eslint-disable-next-line react-hooks/exhaustive-deps
   }, [client, ...dependencies]);
 }
\ No newline at end of file
diff --git a/app/react-components/dom.jsx b/app/react-components/dom.jsx
index 6643941..b041c7a 100644
--- a/app/react-components/dom.jsx
+++ b/app/react-components/dom.jsx
@@ -24,7 +24,7 @@ export default function Dom({children}) {
     return () => {
       window.removeEventListener('resize', onResize);
     }
-  }, [ref.current]);
+  });
   return (
     <div className={styles.dom} ref={ref}>
       {scale > 0 && (
diff --git a/app/react-components/ecs.jsx b/app/react-components/ecs.jsx
index 35ba39c..cda3c4c 100644
--- a/app/react-components/ecs.jsx
+++ b/app/react-components/ecs.jsx
@@ -4,8 +4,6 @@ import {useState} from 'react';
 import {RESOLUTION} from '@/constants.js';
 import {useEcs} from '@/context/ecs.js';
 import {useMainEntity} from '@/context/main-entity.js';
-import Components from '@/ecs-components/index.js';
-import Systems from '@/ecs-systems/index.js';
 import usePacket from '@/hooks/use-packet.js';
 
 import Entities from './entities.jsx';
diff --git a/app/routes/_main-menu.play.$.$/route.jsx b/app/routes/_main-menu.play.$.$/route.jsx
index 159dabe..fbf65d2 100644
--- a/app/routes/_main-menu.play.$.$/route.jsx
+++ b/app/routes/_main-menu.play.$.$/route.jsx
@@ -43,7 +43,7 @@ export default function PlaySpecific() {
     if ('local' !== type) {
       return;
     }
-    async function onBeforeUnload(event) {
+    async function onBeforeUnload() {
       client.disconnect();
       function waitForSave() {
         return new Promise((resolve) => setTimeout(resolve, 0));
diff --git a/app/util/script.js b/app/util/script.js
index 426538c..79975e0 100644
--- a/app/util/script.js
+++ b/app/util/script.js
@@ -146,4 +146,4 @@ export default class Script {
     );
   }
 
-};
+}
diff --git a/app/util/ticking-promise.test.js b/app/util/ticking-promise.test.js
index a06f8fc..0c71fa7 100644
--- a/app/util/ticking-promise.test.js
+++ b/app/util/ticking-promise.test.js
@@ -4,7 +4,7 @@ import TickingPromise from './ticking-promise.js';
 
 test('runs executor', async () => {
   expect(
-    await new TickingPromise((resolve, reject) => {
+    await new TickingPromise((resolve) => {
       resolve(32);
     }),
   )